Merged
Conversation
choo121600
approved these changes
Nov 21, 2025
Member
choo121600
left a comment
There was a problem hiding this comment.
Thanks!
But I’m also wondering how the CI check passed
Member
|
The ci is outdated when the pr is merged. |
Member
|
@guan404ming |
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* fix(ui): fix build failures in clear task instances * fix: resolve lint errors
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* fix(ui): fix build failures in clear task instances * fix: resolve lint errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
#56351
Why
TypeScript compilation errors and ESLint issues are currently causing the UI build to fail.
(Not sure how it passed CI 🤔)
Changes
useClearTaskInstances.ts:.bodyaccess on the error object (the error object structure is{ detail: ... }, not{ body: { detail: ... } }).no-unnecessary-boolean-literal-compareerror by removing=== true.object-shorthanderror.ClearTaskInstanceConfirmationDialog.tsx:ifstatement and sorted props).dags.json:Testing
pnpm lint:fix&pnpm formatlocally and confirmed no type errors.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.